chore: Update AWS SDK to v2 - #19205
Merged
Merged
Conversation
Upgrades everything but dynamodb_storage_client.go:query to V2; the "query" method will need further work.
Mostly error handling; needs to be tested.
Signed-off-by: Sophie Waldman <sophie.waldman@grafana.com>
sophiewaldman
marked this pull request as ready for review
September 26, 2025 17:33
chaudum
added a commit
that referenced
this pull request
Dec 4, 2025
This PR fixes a regression in how Loki's S3 configuration options are handled to create the S3 client which was introduced with the upgrade of the AWS SDK from v1 to v2 (#19205). With the v1 SDK the `s3` field of the `aws` configuration block was parsed to extract credentials, region, host, and schema. ``` storage_config: aws: s3: s3://<accesskey>:<secret>@<endpoint_or_region>/<bucketnames> ``` After the upgrade, only credentials were extraced, leaving all other parts of the URL as default, which would require explicit overrides. This was a breaking change and not documented in the upgrade notes. We want to keep backwards compatibility, even though the Thanos object client is going to supersed the custom S3/GCS/... clients. ref: #19908 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
added a commit
that referenced
this pull request
Dec 4, 2025
### Summary This PR fixes a regression in how Loki's S3 configuration options are handled to create the S3 client which was introduced with the upgrade of the AWS SDK from v1 to v2 (#19205). With the v1 SDK the `s3` field of the `aws` configuration block was parsed to extract credentials, region, host, and schema. ``` storage_config: aws: s3: s3://<accesskey>:<secret>@<endpoint_or_region>/<bucketnames> ``` After the upgrade, only credentials were extraced, leaving all other parts of the URL as default, which would require explicit overrides. This was a breaking change and not documented in the upgrade notes. We want to keep backwards compatibility, even though the Thanos object client is going to supersed the custom S3/GCS/... clients. ref: #19908 Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
![grafana-delivery-bot[bot]](https://cdn.statically.io/img/github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
### Summary This PR fixes a regression in how Loki's S3 configuration options are handled to create the S3 client which was introduced with the upgrade of the AWS SDK from v1 to v2 (#19205). With the v1 SDK the `s3` field of the `aws` configuration block was parsed to extract credentials, region, host, and schema. ``` storage_config: aws: s3: s3://<accesskey>:<secret>@<endpoint_or_region>/<bucketnames> ``` After the upgrade, only credentials were extraced, leaving all other parts of the URL as default, which would require explicit overrides. This was a breaking change and not documented in the upgrade notes. We want to keep backwards compatibility, even though the Thanos object client is going to supersed the custom S3/GCS/... clients. ref: #19908 Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit d3f9532)
nlowe
added a commit
to nlowe/homelab
that referenced
this pull request
Dec 6, 2025
Loki 3.6.x had an unlisted breaking change in s3 endpoint parsing due to an AWS SDK Upgrade and is broken until 3.6.3. See the following: * grafana/loki#19205 * grafana/loki#19908 * grafana/loki#20110 * grafana/loki#20120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The first version of the AWS SDK for Go reached end of support on 2025-07-31. This PR migrates us to V2 of the SDK which is still supported.
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/1426
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR