Skip to content

Conversation

@Mayank85Y
Copy link

What this PR does / why we need it:
Webhook certificate end up mounting up and failing due to incorrect webhook secret name "loki-operator-controller-manager-service-cert". After deploying Loki operator it gets stuck in container creating because secret with specified name is never created.
It need to be changed to "loki-operator-webhook-server-cert" from "loki-operator-controller-manager-service-cert" so that container don't get stuck.

Which issue(s) this PR fixes:
Fixes #19245

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2025

CLA assistant check
All committers have signed the CLA.

@JoaoBraveCoding JoaoBraveCoding changed the title fix: update webhook certificate name from loki-operator-controller-manager-service-cert to loki-operator-webhook-server-cert Oct 8, 2025
go.work Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove this file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve removed the requested file. Please review and let me know if any further changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants