Skip to content

fix(helm): FOLDER_ANNOTATION in ruler & single-binary #19593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix(helm): FOLDER_ANNOTATION in ruler & single-binary #19593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(helm): FOLDER_ANNOTATION in ruler & single-binary
  • Loading branch information
@vrivellino
vrivellino committed Nov 2, 2025
commit df9a5dd88ebd9f815e575298b1c7806638ca2899
1 change: 1 addition & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Entries should be ordered as follows:
Entries should include a reference to the pull request that introduced the change.

## Unreleased
- [BUGFIX] Set `FOLDER_ANNOTATION` in Distributed and SingleBinary deployments. [#19593](https://github.com/grafana/loki/pull/19593)
Copy link
Contributor

@Sheikh-Abubaker Sheikh-Abubaker Nov 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [BUGFIX] Set `FOLDER_ANNOTATION` in Distributed and SingleBinary deployments. [#19593](https://github.com/grafana/loki/pull/19593)
- [ENHANCEMENT] Set `FOLDER_ANNOTATION` in Distributed and SingleBinary deployments. [#19593](https://github.com/grafana/loki/pull/19593)

I believe this could be categorised as enhancement ? since it's not really a bug rather extending the feature to the different deployment modes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning was that the enhancement was #13289, but happy to switch the category - whatever you and other maintainers think

## 6.45.2

Expand Down
4 changes: 4 additions & 0 deletions production/helm/loki/templates/ruler/statefulset-ruler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ spec:
{{- end }}
- name: FOLDER
value: "{{ .Values.sidecar.rules.folder }}"
{{- if .Values.sidecar.rules.folderAnnotation }}
- name: FOLDER_ANNOTATION
value: "{{ .Values.sidecar.rules.folderAnnotation }}"
{{- end }}
- name: RESOURCE
value: {{ quote .Values.sidecar.rules.resource }}
{{- if .Values.sidecar.enableUniqueFilenames }}
Expand Down
4 changes: 4 additions & 0 deletions production/helm/loki/templates/single-binary/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ spec:
{{- end }}
- name: FOLDER
value: "{{ .Values.sidecar.rules.folder }}"
{{- if .Values.sidecar.rules.folderAnnotation }}
- name: FOLDER_ANNOTATION
value: "{{ .Values.sidecar.rules.folderAnnotation }}"
{{- end }}
- name: RESOURCE
value: {{ quote .Values.sidecar.rules.resource }}
{{- if .Values.sidecar.enableUniqueFilenames }}
Expand Down
Loading