Skip to content

fix(helm): support global registry override for sidecar #19671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helm): support global registry override for sidecar #19671

wants to merge 1 commit into from

Conversation

@Scrumplex
Copy link

What this PR does / why we need it:

Since #19246 the sidecar image would resolve to <registry-mirror>/docker.io/kiwigrid/k8s-sidecar when a global registry mirror was defined.

This commit handles the registry properly, the same way as all the other docker hub images.

Which issue(s) this PR fixes:

Special notes for your reviewer:

I have tested this using helm template. Without a global registry the output is unchanged. With a global registry, it is now resolved properly.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@Scrumplex Scrumplex requested a review from a team as a code owner October 31, 2025 21:44
@Scrumplex
fix(helm): support global registry override for sidecar
3553219 
Since grafana#19246 the sidecar image would
resolve to registry-mirror.example.com/docker.io/kiwigrid/k8s-sidecar
when a global registry mirror was defined.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex force-pushed the fix/helm/sidecar-global-registry branch from 8de306b to 3553219 Compare October 31, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S

1 participant

@Scrumplex