refactor(ingestor): WAL Replay controller: Use singleflight to ensure only one inflight flush is happening - #19831
Merged
Segflow merged 8 commits intoNov 12, 2025
Conversation
…lex mutex & cond logic
Contributor
Author
|
Benchmark shows it's slightly faster (but negligeable) : Before the change (using mutex and cond) After the change (using singleflight) |
…github.com:grafana/loki into refactor-ingester-replay-controll-use-singleflight
…github.com:grafana/loki into refactor-ingester-replay-controll-use-singleflight
Segflow
deleted the
refactor-ingester-replay-controll-use-singleflight
branch
November 12, 2025 14:38
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When going through the codebase to understand how we replaying the WAL etc.. I come across this interesting piece of code and I thought I could simplify it by using the
singleflightpackage instead of current approach (complexsync.Mutexandsync.Cond)Special notes for your reviewer:
The previous approach work just fine and passes the new test too. This is only to make things easier to reason about.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR