fix(helm): add temporary storage volume and mount for sidecar rules - #19973
Closed
jkroepke wants to merge 1 commit into
Closed
fix(helm): add temporary storage volume and mount for sidecar rules#19973jkroepke wants to merge 1 commit into
jkroepke wants to merge 1 commit into
Conversation
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
6 tasks
Contributor
Author
|
Reason: #19939 (comment) |
| {{- end }} | ||
| - name: tmp | ||
| emptyDir: {} | ||
| {{- if .Values.sidecar.rules.enabled }} |
Contributor
There was a problem hiding this comment.
Should this not be behind {{- if and .Values.sidecar.rules.enabled .Values.ruler.sidecar }}? Otherwise LGTM
Contributor
|
As of March 16, 2026, the Loki Helm Chart has been forked to the new Grafana-Community/helm-charts repo and is now being maintained by the Grafana Community and Grafana Champions. If this PR is needed for a Grafana Enterprise Logs (GEL) release, please leave a comment. Otherwise, please reopen your pull request here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR