Skip to content

fix: Add build tags to Promtail build commands - #19989

Merged
spiridonov merged 2 commits into
grafana:mainfrom
JohanLindvall:patch-1
Mar 6, 2026
Merged

fix: Add build tags to Promtail build commands#19989
spiridonov merged 2 commits into
grafana:mainfrom
JohanLindvall:patch-1

Conversation

@JohanLindvall

Copy link
Copy Markdown
Contributor

Fixes #19911

What this PR does / why we need it:
Re-enables journald support for promtail

Which issue(s) this PR fixes:
Fixes #19911

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@JohanLindvall
JohanLindvall requested a review from a team as a code owner November 24, 2025 12:33
@HendrikR

Copy link
Copy Markdown

It looks like some checks did not finish properly, can someone retrigger the checks?

Comment thread Makefile
@spiridonov

Copy link
Copy Markdown
Contributor

Thanks for the fix @JohanLindvall !

@JohanLindvall

Copy link
Copy Markdown
Contributor Author

@spiridonov The changes you request are reasonable, but would require a larger refactoring of the Makefile, which I think someone with more insight into the future of the product stack should do.

@CLAassistant

CLAassistant commented Feb 20, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@JohanLindvall JohanLindvall reopened this Feb 25, 2026
@JohanLindvall

Copy link
Copy Markdown
Contributor Author

Force pushed and recreated to get rid of spam merge

@spiridonov
spiridonov merged commit 5596bdc into grafana:main Mar 6, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants