fix: Add build tags to Promtail build commands - #19989
Merged
Merged
Conversation
|
It looks like some checks did not finish properly, can someone retrigger the checks? |
spiridonov
requested changes
Feb 17, 2026
Contributor
|
Thanks for the fix @JohanLindvall ! |
Contributor
Author
|
@spiridonov The changes you request are reasonable, but would require a larger refactoring of the Makefile, which I think someone with more insight into the future of the product stack should do. |
spiridonov
approved these changes
Feb 20, 2026
JohanLindvall
force-pushed
the
patch-1
branch
from
February 25, 2026 09:51
e697eec to
ced1d1b
Compare
Contributor
Author
|
Force pushed and recreated to get rid of spam merge |
This was referenced Apr 1, 2026
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19911
What this PR does / why we need it:
Re-enables journald support for promtail
Which issue(s) this PR fixes:
Fixes #19911
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR