fix(engine): fix additional instances of writing/reading on a closed conn - #20982
Merged
Conversation
…connection There were a few more remaining instances where peers could attempt to read or write over a closed connection. In the case of a server doing this, it resulted in a panic. Other cases were generally handled ungracefully as it didn't return the expected error type.
ivkalita
approved these changes
Feb 26, 2026
ivkalita
added a commit
that referenced
this pull request
Feb 26, 2026
A followup on #20982 to handle more http2 errors.
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few more remaining instances where peers could attempt to read or write over a closed connection. In the case of a server doing this, it resulted in a panic. Other cases were generally handled ungracefully as it didn't return the expected error type.