fix(query-engine): Fix OR operations being silently dropped - #21204
Merged
Conversation
trevorwhitney
approved these changes
Mar 19, 2026
trevorwhitney
left a comment
trevorwhitney
left a comment
Collaborator
There was a problem hiding this comment.
looks good, nice catch, but does this mean we're also missing and operations?
| func convertLineFilterExpr(expr *syntax.LineFilterExpr) Value { | ||
| current := convertLineFilter(expr.LineFilter) | ||
|
|
||
| if expr.Or != nil { |
Collaborator
There was a problem hiding this comment.
does this mean we're also missing and operations?
Contributor
Author
There was a problem hiding this comment.
I replied to Trevor offline but for others following this PR: we somehow don't support and operations in line filters, just labels filters, I was somewhat surprised by that.
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our line filter conversion isn't looking at Or operations when materializing the AST, causing the second option of the OR filter to be silently dropped.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR