fix(compactor): Fix delete request when using Thanos objstore client with filesystem backend [release-3.7.x] - #22811
Merged
Conversation
…with filesystem backend (#22809) The compactor selected the chunk-key encoder via a concrete type assertion on *local.FSObjectClient. With use_thanos_objstore enabled the object client is a *bucket.ObjectClientAdapter, so FSEncoder was skipped and chunks were looked up with raw, un-encoded keys. This diverged from the keys written by the rest of the storage stack (storage.NewChunkClient applies FSEncoder for the thanos filesystem backend), causing chunk rewrites during retention to fail and line-filter delete requests to remain stuck in the received state. (cherry picked from commit eae43e1) Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Contributor
|
Expand for findings |
jnewbigin
approved these changes
Jul 16, 2026
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport eae43e1 from #22809 job run
Summary
The compactor selected the chunk-key encoder via a concrete type assertion on *local.FSObjectClient. With use_thanos_objstore enabled the object client is a *bucket.ObjectClientAdapter, so FSEncoder was skipped and chunks were looked up with raw, un-encoded keys. This diverged from the keys written by the rest of the storage stack (storage.NewChunkClient applies FSEncoder for the thanos filesystem backend), causing chunk rewrites during retention to fail and line-filter delete requests to remain stuck in the received state.