Canary: Add -actor CLI flag to be able to set the X-Loki-Actor-Path HTTP header for query requests
#8889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/canary-actor
branch
from
5ed76e5 to
0f8e406
Compare
chaudum
force-pushed
the
chaudum/canary-actor
branch
from
0f8e406 to
3932338
Compare
chaudum
force-pushed
the
chaudum/canary-actor
branch
3 times, most recently
from
9f65234 to
229861a
Compare
chaudum
force-pushed
the
chaudum/canary-actor
branch
from
229861a to
cbe34b4
Compare
pkg/canary/reader/reader.go
Outdated
| user string, | ||
| pass string, | ||
| tenantID string, | ||
| actorPath string, |
There was a problem hiding this comment.
Why the name actorpath here? Can't this be actor as well?
There was a problem hiding this comment.
Right, it can just be actor.
chaudum
force-pushed
the
chaudum/canary-actor
branch
from
cbe34b4 to
0688a58
Compare
jeschkies
reviewed
Apr 12, 2023
| // the set headers. | ||
| // If the passed request is nil, a new temporary request object is created. | ||
| // This is useful for creating the headers only. | ||
| func (r *Reader) ApplyHeaders(req *http.Request) http.Header { |
There was a problem hiding this comment.
Could you add a test for this method?
chaudum
force-pushed
the
chaudum/canary-actor
branch
from
0688a58 to
c6d91ef
Compare
The CLI argument allows to set the `X-Loki-Actor-Path` HTTP header for requests of the reader. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/canary-actor
branch
from
eb67ddf to
4408460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI argument allows to set the
X-Loki-Actor-PathHTTP header for requests of the reader.What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md