Runs make fmt over the whole repo

[owen-d]

Some format housekeeping

[DylanGuedes]

lgtm with some nits

[DylanGuedes]

hmm this one is isolated from other packages below (I'm not adding a diff suggestion for you to just apply because the order would be wrong anyway)

[DylanGuedes]

ditto: this one after dskit/tenant package

[periklis]

@owen-d FYI this touches sources in the operator sub folder and it looks like we use different formatting styles

[owen-d]

Hey @periklis is that ok? This all comes from the goimports -local configs.

$ goimports --help
usage: goimports [flags] [path ...]
  -local string
        put imports beginning with this string after 3rd-party packages; comma-separated list

which is called by make format

format:
	find . $(DONT_FIND) -name '*.pb.go' -prune -o -name '*.y.go' -prune -o -name '*.rl.go' -prune -o \
		-type f -name '*.go' -exec gofmt -w -s {} \;
	find . $(DONT_FIND) -name '*.pb.go' -prune -o -name '*.y.go' -prune -o -name '*.rl.go' -prune -o \
		-type f -name '*.go' -exec goimports -w -local github.com/grafana/loki {} \;

We can exclude the operator dir from the make format command if you'd prefer, but I personally like the formatting changes. WDYT?

[periklis]

Hey @periklis is that ok? This all comes from the goimports -local configs.

$ goimports --help
usage: goimports [flags] [path ...]
  -local string
        put imports beginning with this string after 3rd-party packages; comma-separated list

which is called by make format

format:
	find . $(DONT_FIND) -name '*.pb.go' -prune -o -name '*.y.go' -prune -o -name '*.rl.go' -prune -o \
		-type f -name '*.go' -exec gofmt -w -s {} \;
	find . $(DONT_FIND) -name '*.pb.go' -prune -o -name '*.y.go' -prune -o -name '*.rl.go' -prune -o \
		-type f -name '*.go' -exec goimports -w -local github.com/grafana/loki {} \;

We can exclude the operator dir from the make format command if you'd prefer, but I personally like the formatting changes. WDYT?

I would like to skip the operator dir for now. As per now it would make backport bugs harder. I suggest the SIG operator lifts the exclude once we have applied goimports on main and present release branches`.

[jeschkies]

Thanks. I was hesitating to do this because I feared it would mess up git blame. However, these are just imports.

Once this land we can simplify the make check-format step.