Azure: Create blob container if not found. #9595
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR aligns with the fallback behavior in Thanos object store for creating azure blob containers when they do not exist. Loki depends on the containers to function and already configures the necessary credentials for creating a container. It follows that Loki should create any required containers to prevent running in a failed state.
This behavior matches the code for Thanos here:
https://github.com/thanos-io/objstore/blob/main/providers/azure/azure.go#L167
I tried to match the behavior as closely as possible while using the existing
azblob
implementation in Loki (vs the azure sdk library in Thanos object store).Which issue(s) this PR fixes:
Fixes #9467
Special notes for your reviewer:
Re-opened due to changing the default branch. Continuation of #9466
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updateddocs/sources/upgrading/_index.md