Skip to content

jsonnet: fix for tsdb config #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

jsonnet: fix for tsdb config #9836

wants to merge 6 commits into from

Conversation

manohar-koukuntla
Copy link
Contributor

@manohar-koukuntla manohar-koukuntla commented Jun 30, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #9789

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
@manohar-koukuntla
Copy link
Contributor Author

@chaudum I missed this in my last PR #9790
@manohar-koukuntla manohar-koukuntla marked this pull request as ready for review June 30, 2023 10:03
@manohar-koukuntla manohar-koukuntla requested a review from a team as a code owner June 30, 2023 10:03
@manohar-koukuntla manohar-koukuntla changed the title fix for tsdb config Jun 30, 2023
sid-maddy
sid-maddy suggested changes Jun 30, 2023
View reviewed changes
chaudum
chaudum reviewed Jun 30, 2023
View reviewed changes
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 11, 2023
@manohar-koukuntla
Copy link
Contributor Author

@chaudum Friendly bump
@chaudum
Copy link
Contributor

chaudum commented Jul 11, 2023 •
edited
Loading

@chaudum Friendly bump

I think this change very likely breaks existing installations that use different shared stores for BoltDB and TSDB. Let me try to evaluate the changes.
@chaudum
Copy link
Contributor

chaudum commented Jul 11, 2023

@chaudum Friendly bump

I think this change very likely breaks existing installations that use different shared stores for BoltDB and TSDB. Let me try to evaluate the changes.

@manohar-koukuntla I am not entirely sure what the change actually fixes, except that there is a single shared_store variable for the compactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
3 participants
@manohar-koukuntla @chaudum @sid-maddy