fix: always fixup schemes of Grafana client based on final Grafana URL #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructing the Grafana client we need to ensure that it doesn't try to use HTTPS when the final Grafana URL scheme is HTTP. This particularly affects the case where the Grafana URL is not provided and the server is running on SSE mode. This is because: - in stdio mode we use `ExtractGrafanaClientFromEnv`, which falls back to explicitly using the `defaultGrafanaURL` variable if the GRAFANA_URL environment variable is not set, so a non-empty value is passed to `NewGrafanaClient` - in SSE mode we use `ExtractGrafanaClientFromHeaders`, which does not fall back to `defaultGrafanaURL` and instead passes an empty string, therefore relying on the `NewGrafanaClient` to use the default schemes. Fixes #162.
ioanarm
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing the Grafana client we need to ensure that it doesn't
try to use HTTPS when the final Grafana URL scheme is HTTP.
This particularly affects the case where the Grafana URL is not
provided and the server is running on SSE mode. This is because:
ExtractGrafanaClientFromEnv, which fallsback to explicitly using the
defaultGrafanaURLvariable if theGRAFANA_URL environment variable is not set, so a non-empty value
is passed to
NewGrafanaClientExtractGrafanaClientFromHeaders, which does notfall back to
defaultGrafanaURLand instead passes an empty string,therefore relying on the
NewGrafanaClientto use the defaultschemes.
Fixes #162.