store-gateway: change old blocks to be reported as 'unknown/old_block' in metrics #11891
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newly shipped blocks get level 1. Level 0 indicates that the block's metadata was included in the bucket index before we started adding compaction level information (pre-January 2024). This change improves metric clarity by distinguishing between blocks with genuinely unknown levels versus blocks that were legitimately created before the compaction level field was added.
dimitarvdimitrov
changed the title
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
tacole02
approved these changes
Jun 27, 2025
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level 0 blocks in metrics indicate metadata from before we started tracking compaction levels in bucket index (pre-January 2024). This change improves metric clarity by labeling them as 'unknown/old_block' instead of '0'.
Background:
Blocks are correctly created with level 1 in Prometheus compactor:
meta.Compaction.Level = 1meta.Compaction.Level = 1CompactionLevel field was added to bucket index in dcc2d9bb (January 2024)
The
updateBlockIndexEntryfunction only runs for new blocks, which explains why existing blocks had zero-valued compaction level.Discovered while working on #11803.