-
Notifications
You must be signed in to change notification settings - Fork 658
helm: Added trafficDistribution configuration option to distributor, gateway, querier, query-frontend, query-scheduler, ingester, and store-gateway services
#12243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for this PR, I was just about to even open an issue for this to be added to the charts. |
|
Hi, I’ve updated the #fixes link based on my understanding. |
|
This is a great feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also add an entry to the CHANGELOG.md file in operations/helm/charts/mimir-distributed?
operations/helm/charts/mimir-distributed/templates/ingester/ingester-svc.yaml
Show resolved
Hide resolved
operations/helm/charts/mimir-distributed/templates/nginx/nginx-svc.yaml
Outdated
Show resolved
Hide resolved
operations/helm/charts/mimir-distributed/templates/store-gateway/store-gateway-svc.yaml
Show resolved
Hide resolved
- Add CHANGELOG entry for trafficDistribution enhancement - Remove trafficDistribution from deprecated nginx service - Add clarifying comments for ingester and store-gateway services - Add missing documentation comments for all trafficDistribution fields Resolves reviewer comments on PR grafana#12243
|
thank you for the contribution @Mohijeet can you please sign the CLA? I think it's possible that some of the commits you've pushed are with a different author than the one in your github profile (which supposedly signed the CLA). Can you check again? This is the only thing blocking merging this now. If you need to re-push commits that's also ok, just be careful to also include the diff that I pushed a few minutes ago. |
- Add CHANGELOG entry for trafficDistribution enhancement - Remove trafficDistribution from deprecated nginx service - Add clarifying comments for ingester and store-gateway services - Add missing documentation comments for all trafficDistribution fields Resolves reviewer comments on PR grafana#12243
What this PR does
This Pull Request (PR) introduces a significant enhancement for specific use cases where a metrics forwarder and Mimir instances are communicating within the same Kubernetes cluster. Currently, there's no native configuration allowing Mimir distributors and ingesters to prioritise same-Availability Zone (AZ) communication for data ingestion, even when cross-AZ replication is disabled.
This PR aims to enable zone-aware data transfer to optimise data ingestion by leveraging existing Kubernetes kube-proxy features for traffic distribution (as described here). By allowing the metrics agent to communicate with same-AZ endpoints of the distributor, NGINX, or gateway (based on configuration), we can achieve more efficient and potentially lower-latency data transfer. This is particularly beneficial for reducing cross-AZ traffic costs and improving overall performance within the cluster
(I added this in readpath to keep things consistent in the querier or querier_frontend during data reads. In the end, the data will still be fetched from Ingesters across different availability zones.)
Which issue(s) this PR fixes or relates to
#10214
Fixes #10214
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.