fix(ebpf): start profiling after attaching perf reader #2812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a tiny time window when we already attach ebpf program to perf event (start profiling) and not yet attached a reader for pid info requests.
So this line some times return 2 (ENOENT) instead of 0, causing userspace program miss some processes to profile.
pyroscope/ebpf/bpf/profile.bpf.c
Line 50 in 8dc366a
This PR changes order of enabling profiling - start reading events first, then start profiling