feat: async profile row iterator #2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
approved these changes
Jan 23, 2024
cyriltovena
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses one of the issues with data streaming in the block read path: when we select profile rows for filtering (by profile series ID and the query time range) we synchronously collect the list of filtered profiles, blocking the data flow. This behaviour has been changed so that filtered profiles are passed down to the stream in batches, asynchronously.
It's not expected that the overall query performance will improve in all cases. Usually the delay caused by the described blocking is very small and does not have impact on the overall query latency and/or resource consumption. However, it may be helpful with huge datasets of high cardinality.