Skip to content

Fix missing icon assets #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 5, 2024
Merged

Fix missing icon assets #2985

merged 5 commits into from
Feb 5, 2024

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Feb 2, 2024 •
edited
Loading

Fixes #2978

This was made possible with grafana/grafana#76191. Alternatively we could just point to the Grafana CDN, but icons take longer to load and we'd add a runtime dependency.
@aleks-p aleks-p requested a review from a team as a code owner February 2, 2024 19:47
@aleks-p aleks-p changed the title Serve Grafana icon assets via a CDN Feb 2, 2024
@Rperry2174 Rperry2174 requested a review from grafakus February 5, 2024 00:21
cyriltovena
cyriltovena approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@cyriltovena cyriltovena merged commit 90b411f into main Feb 5, 2024
@cyriltovena cyriltovena deleted the fix/missing-grafana-icons branch February 5, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@aleks-p @cyriltovena