Skip to content

fix: don't compute delta on relabeled godeltaprof_memory->memory profiles #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

korniltsev
Copy link
Collaborator

No description provided.

@korniltsev korniltsev requested a review from a team as a code owner July 2, 2024 16:13
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There is still a test, that requires updating otherwise good.

Suggest we backport this into weekly/f73

@korniltsev korniltsev merged commit e7cb452 into main Jul 2, 2024
16 checks passed
@korniltsev korniltsev deleted the korniltsev/relabelig_godeltaprof_fix branch July 2, 2024 17:06
korniltsev added a commit that referenced this pull request Jul 2, 2024
…iles (#3398)

* fix: do not compute delta on relabeled godeltaprof_memory->memory profiles

* add repro

* fmt

* fix test

* fix test
korniltsev added a commit that referenced this pull request Jul 3, 2024
…iles (#3398) (#3399)

* fix: do not compute delta on relabeled godeltaprof_memory->memory profiles

* add repro

* fmt

* fix test

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants