perf: add log buffer #3947
Merged
perf: add log buffer #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
added
enhancement
kolesnikovae
force-pushed
the
perf/log-buffer
branch
from
bd7fb1e to
f235195
Compare
|
I decided to use dskit |
korniltsev
approved these changes
Feb 25, 2025
|
Unfortunately, it did not really help: we should make flush non-blocking. 
|
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of unbuffered synchronous logger affects ingestion latency. In the worst case, if the output is redirected to a file, and the disk system does not cope with the log rate, it may cause 10+ sec. p99 spikes. The problem here is that distributors are stateless but may suffer from side-effects caused by neighbours, which makes it hard to identify the culprit.