fix: drop negative samples #3955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
force-pushed
the
fix/negative-samples
branch
from
d5f4dcc to
457d034
Compare
simonswine
approved these changes
Feb 27, 2025
| p.Sample = slices.RemoveInPlace(p.Sample, func(s *profilev1.Sample, i int) bool { | ||
| for j := 0; j < len(s.Value); j++ { | ||
| if s.Value[j] < 0 { | ||
| removedSamples = append(removedSamples, s) |
There was a problem hiding this comment.
Maybe a metric might be helpful in order to tell us if this still happens or not?
There was a problem hiding this comment.
Let's do that in a separate PR
simonswine
pushed a commit
that referenced
this pull request
Feb 27, 2025
This was referenced Feb 28, 2025
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3939 #2285