Fix converting rows with FLOAT4 and BOOLEAN #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From investigating with our external dev credentials, it looks like we were converting Float4 and Boolean from the wrong types. When I set the redshift column to the REAL type, it returned a Float4, so I don't think our issue was that we weren't supporting the type. Also, I suspect that the FLOAT type should also be converted as a double, but in Redshift it's synonymous with DOUBLE and I couldn't get it to actually return that type.
I'm a little suspicious of the solution because it implies either that FLOAT4 has never worked or that AWS changed the return type.
Fixes #204