Do not call ListStatements in GetQueryID #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops calling ListStatements in GetQueryID, which was meant to sort of cache async queries instead of calling them multiple times, but can lead to timeouts if there are a lot of statements. This just returns false every time, since it:
a) is not worse than the synchronous solution (if you started multiple identical sync queries they would not check)
b) in retrospect can be (and hopefully is) handled more gracefully in async query caching (where we can cache a queryID for a query using the existing grafana query caching solution)
(note: we're already returning false every time in the Athena datasource for throttling reasons, so we know this works and I probably should have extrapolated from that)
fixes #250