Chore: replace GetSession with GetSessionWithAuthSettings #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
approved these changes
Jun 7, 2024
pkg/redshift/api/api.go
Outdated
| "strings" | ||
|
|
||
| "github.com/grafana/sqlds/v3" |
There was a problem hiding this comment.
tiny nit: i think this should be part of the lower block of imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates grafana-aws-sdk to make use of grafana/grafana-aws-sdk#144
I checked for usages of
os.LookupEnv,os.Getenv,os.Expandto check for usages for environment variablesGetSessionWithAuthSettingsin place ofGetSessionwhich would read environment variables if there were no AuthSettingsI checked for
fsimports to check for usages of the file systemI checked for shared state by looking for global variables and found 2 things that might be relevant and asked about it here.
Fixes: #278