Migrate E2E tests to Playwright #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
kevinwcyu
force-pushed
the
kevinwcyu/migrate-to-playwright
branch
from
c6bc0c4 to
a4d6e91
Compare
kevinwcyu
force-pushed
the
kevinwcyu/migrate-to-playwright
branch
from
dfc7c7a to
7f52044
Compare
idastambuk
reviewed
Feb 3, 2025
| id="clusterIdText" | ||
| value={props.options.jsonData.clusterIdentifier ?? ''} | ||
| onChange={() => {}} | ||
| {useManagedSecret ? ( |
idastambuk
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/1192
@grafana/e2eandcypresssrc/ConfigEditor/ConfigEditor.tsx: previously it was rendering a disabled input and a select component at the same time. It would hide one depending on whether managed secrets was being used. This would cause multiple elements to be found when selecting by theManaged Secretlabel. The update renders only a singleManaged Secretlabel and corresponding select or input.