Enable dataproxy.row_limit configuration option from Grafana and Prepare 2.1.0 release #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
changed the title
iwysiu
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sqlds based data sources don't make use of the dataproxy.row_limit setting in Grafana. setting. It defaults to an unlimited number of rows. This PR added a setting for data sources to opt-in to using the
row_limitsetting.This PR opts-in to using the
row_limitsetting so that Redshift will now limit the rows returned to the default value of1000000if the user doesn't explicitly set arow_limit.In the screenshot below, I have the following set in my
custom.ini. The warning in the query editor header section shows that the number of results have been limited.