Fix retention to immediately update the in-memory blocklists for changes - #1389
Merged
Conversation
mdisibio
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
yvrhdn and
zalegrala
as code owners
April 15, 2022 16:28
joe-elliott
approved these changes
Apr 15, 2022
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
looks good! minor request if you have a second, but no worries if you just want to click that big green button
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…ges (grafana#1389) * Fix retention to immediately update the in-memory blocklists for changes * add missing break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes retention to immediately update the in-memory blocklist for changes. This prevents errors if retention runs twice before the next polling cycle, where it would try to retain the same block twice.
Note - We already do this after compaction, but it only added compactedMeta. Now we are removing too, so there is a new function param and test cases in
blocklist.Update.Which issue(s) this PR fixes:
Fixes part of #1372
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]