Log when a trace is too large to compact - #2105
Merged
mapno merged 1 commit intoFeb 24, 2023
Merged
Conversation
scalalang2
requested review from
annanay25,
joe-elliott,
mapno,
mdisibio,
yvrhdn and
zalegrala
as code owners
February 14, 2023 05:10
scalalang2
commented
Feb 14, 2023
joe-elliott
reviewed
Feb 14, 2023
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
two comments. looking good!
scalalang2
force-pushed
the
scalalang2/log-when-traces-are-too-large
branch
2 times, most recently
from
February 15, 2023 02:17
42a31fd to
9e848ef
Compare
scalalang2
commented
Feb 15, 2023
joe-elliott
reviewed
Feb 21, 2023
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
this is looking good. two small comments.
i forgot that v2 and vParquet have different paths for counting dropped spans. thank you for tracking this down. i suppose ultimately we'd prefer both act like vParquet does, but that's too much change for this PR.
scalalang2
force-pushed
the
scalalang2/log-when-traces-are-too-large
branch
from
February 23, 2023 02:36
9e848ef to
df93a32
Compare
joe-elliott
approved these changes
Feb 23, 2023
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
Nice! Thanks for this improvement. It looks like there's a conflict in the changelog. If you can clean that up we'll merge.
scalalang2
force-pushed
the
scalalang2/log-when-traces-are-too-large
branch
from
February 24, 2023 01:24
df93a32 to
3dfe897
Compare
Contributor
Author
|
I cleaned changelog, thanks joe :) |
scalalang2
force-pushed
the
scalalang2/log-when-traces-are-too-large
branch
from
February 24, 2023 01:27
3dfe897 to
1e0a4fe
Compare
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Log when a trace is too large to compact.
If the total bytes of traces exceeds maximum limit, the following messages will be logged.
{ "msg": "max size of trace exceeded", "tenant": "XXXXX", "traceId": "XXXXX", "discarded_span_count": 100 }There will be some dicussions in this PR.
Please refer to following comments.
Which issue(s) this PR fixes:
Fixes #1931
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]