Rework SLO metrics - #2840
Merged
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
electron0zero,
ie-pham,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
August 24, 2023 14:18
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
zalegrala
reviewed
Aug 25, 2023
zalegrala
left a comment
zalegrala
left a comment
Contributor
There was a problem hiding this comment.
This looks reasonable to me. Just a question about tracking the other operations. Have you had a chance to test this out?
Signed-off-by: Joe Elliott <number101010@gmail.com>
mdisibio
approved these changes
Aug 25, 2023
mdisibio
left a comment
mdisibio
left a comment
Contributor
There was a problem hiding this comment.
LGTM, accuracy of the metrics for SLO calculation is important and I think this is a good change. I think this is Tempo's first case of context smuggling so it gets a pass. 😄
zalegrala
approved these changes
Aug 25, 2023
zalegrala
left a comment
zalegrala
left a comment
Contributor
There was a problem hiding this comment.
Nice work Joe. Thanks for giving this area some ❤️ .
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* better align total queries Signed-off-by: Joe Elliott <number101010@gmail.com> * comments Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * first pass new slo structure Signed-off-by: Joe Elliott <number101010@gmail.com> * added slos.go Signed-off-by: Joe Elliott <number101010@gmail.com> * pass throughput correctly Signed-off-by: Joe Elliott <number101010@gmail.com> * Added SLOs to streaming Signed-off-by: Joe Elliott <number101010@gmail.com> * correct metrics order Signed-off-by: Joe Elliott <number101010@gmail.com> * added tests. fixed calcs Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * safety check and postSLOHook Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * e2e Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR reworks the way our SLO metrics are recorded with these goals in mind;
This PR accomplishes the above with the following sharp corners:
TODO
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]