Support for search by status message in traceql - #2848
Conversation
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
This is looking really great so far 👍 Since this is a new feature I think it's ok to only support the statusMessage intrinsic in TraceQL and not the status.message label for tag-based search. The old tag-based search is deprecated and going away (in the UI and in Tempo).
Got it, removed. It's ready for review. Let me know what you think! |
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Tested locally and it's working great. One last thing before we merge - Let's add it to the list of intrinsics in https://github.com/grafana/tempo/blob/main/docs/sources/tempo/traceql/_index.md#intrinsic-fields. We can use the definition optional text accompanying the span status.
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for updating the documentation.
* Support searching by status message field * Fix proto to parquet column name mapping * remove status message from tag search * Convert parquet column name to intrinsic name * Add changelog entry * Generate yacc * Add related documentation
3 participants
What this PR does:
Which issue(s) this PR fixes:
Fixes #2655
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]