Skip to content

Add spanmetrics, servicegraph histogram buckets to user-configurable overrides api - #2928

Merged
yvrhdn merged 4 commits into
mainfrom
overrides-api-histogram-buckets
Sep 22, 2023
Merged

Add spanmetrics, servicegraph histogram buckets to user-configurable overrides api#2928
yvrhdn merged 4 commits into
mainfrom
overrides-api-histogram-buckets

Conversation

@mar4uk

@mar4uk mar4uk commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

What this PR does:
Extends the user-configurable overrides added in #2543 with histogram buckets override.

New JSON payload:

{
    "forwarders": [],
    "metrics_generator": {
        "processors": [
            "service-graphs",
            "span-metrics"
        ],
        "disable_collection": false,
        "collection_interval": "60s",
        "processor": {
            "service_graphs": {
                "dimensions": [
                    "service.namespace"
                ],
                "enable_client_server_prefix": true,
                "peer_attributes": [
                    "peer.service",
                    "db.name",
                    "db.system",
                    "db.url"
                ],
                "histogram_buckets": [0, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10]
            },
            "span_metrics": {
                "dimensions": [
                    "service.namespace"
                ],
                "enable_target_info": true,
                "histogram_buckets": [0, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10],
                "filter_policies": [
                    {
                        "include": {
                            "match_type": "strict",
                            "attributes": [
                                {
                                    "key": "span.kind",
                                    "value": "SPAN_KIND_SERVER"
                                }
                            ]
                        }
                    },
                    {
                        "include": {
                            "match_type": "strict",
                            "attributes": [
                                {
                                    "key": "span.kind",
                                    "value": "SPAN_KIND_CLIENT"
                                }
                            ]
                        }
                    }
                ]
            }
        }
    }
}

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
@CLAassistant

CLAassistant commented Sep 13, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mar4uk
mar4uk force-pushed the overrides-api-histogram-buckets branch from 911329a to 0859531 Compare September 13, 2023 15:27
@mar4uk
mar4uk marked this pull request as ready for review September 13, 2023 16:20
Koenraad Verheyden added 3 commits September 22, 2023 18:33
# Conflicts:
#	CHANGELOG.md
#	modules/overrides/user_configurable_overrides.go
#	modules/overrides/user_configurable_overrides_test.go
#	modules/overrides/userconfigurable/client/limits.go

@yvrhdn yvrhdn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, this is looking good! I've just merged in the latest changes from main and fixed a typo.

@yvrhdn
yvrhdn merged commit d1b478b into main Sep 22, 2023
@yvrhdn
yvrhdn deleted the overrides-api-histogram-buckets branch September 22, 2023 17:29
mattdurham pushed a commit to mattdurham/tempo that referenced this pull request Jun 18, 2026
…overrides api (grafana#2928)

* Add spanmetrics, servicegraph histogram buckets to user-configurable overrides api

* Linting

* Fix typo

---------

Co-authored-by: Koenraad Verheyden <koenraad.verheyden@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants