make the traceID label name configurable - #3074
Conversation
|
|
|
should I add a new config to legacy config - or adjust this test? |
joe-elliott
left a comment
joe-elliott
left a comment
There was a problem hiding this comment.
This generally looks good to me! What is the goal here? Do we need this to be per tenant?
I'm not going to approve b/c I'd like @kvrhdn to take a look regarding how this interacts with overrides/user configurable overrides.
I think ultimately we want to migrate everyone over, so I see this as a feature flag. |
knylander-grafana
left a comment
knylander-grafana
left a comment
There was a problem hiding this comment.
Thank you for adding documentation. The update looks good.
|
@knylander-grafana fixed build |
yvrhdn
left a comment
yvrhdn
left a comment
There was a problem hiding this comment.
Looks good to me, no comments besides that we don't need to do anything for user-configurable overrides.
|
@kvrhdn can this be merged now? |
addressed |
yvrhdn
left a comment
yvrhdn
left a comment
There was a problem hiding this comment.
Yep, this looks good to me. Thanks!
* make the traceID label name configurable, because otel specifies trace_id - see https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars * make the traceID label name configurable, because otel specifies trace_id - see https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars * make the traceID label name configurable, because otel specifies trace_id - see https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars * make the traceID label name configurable, because otel specifies trace_id - see https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars * make the traceID label name configurable, because otel specifies trace_id - see https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars * make the traceID label name configurable, because otel specifies trace_id - see https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars
5 participants
What this PR does: make the traceID label name configurable, especially to make it possible to be otel compliant: https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#exemplars
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]