Fix Exit code for -config.verify - #3174
Merged
Merged
Conversation
bugfix(SPI-1630): fix exit status if config is valid
agrib-01
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
November 23, 2023 13:39
mapno
approved these changes
Nov 23, 2023
mapno
left a comment
mapno
left a comment
Contributor
There was a problem hiding this comment.
Oh wow, I wonder how long we've had this bug for.
Thanks for the fix!
mapno
reviewed
Nov 23, 2023
link to the PR
Contributor
Author
Not for too long. This issue wasn't present in version 2.2.3 :D |
mapno
approved these changes
Nov 23, 2023
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* bugfix(SPI-1630): fix exit status if config is valid * Update CHANGELOG.md link to the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR corrects the exit status behavior in Tempo. Now, when -config.verify=true is used and the configuration is valid, the application will exit with status 0.
Which issue(s) this PR fixes:
Fixes #3172
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]