Skip to content

Precalculate and reuse the vParquet3 schema before opening blocks - #3367

Merged
stoewer merged 2 commits into
grafana:mainfrom
stoewer:calculate-parquet-schema-once
Feb 6, 2024
Merged

Precalculate and reuse the vParquet3 schema before opening blocks#3367
stoewer merged 2 commits into
grafana:mainfrom
stoewer:calculate-parquet-schema-once

Conversation

@stoewer

@stoewer stoewer commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

What this PR does:

Precalculate and reuse the vParquet3 schema. This performance optimization saves a small amount of CPU time when blocks are opened for search

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
@stoewer stoewer changed the title vParquet3: calculate the parquet schema only once Feb 6, 2024
This saves a small amount of CPU time when blocks are opened
@stoewer
stoewer force-pushed the calculate-parquet-schema-once branch from 4bf27dc to acbc7e4 Compare February 6, 2024 00:34
@stoewer
stoewer marked this pull request as ready for review February 6, 2024 05:15

@mapno mapno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoewer
stoewer merged commit 5b739f8 into grafana:main Feb 6, 2024
@stoewer
stoewer deleted the calculate-parquet-schema-once branch February 6, 2024 22:25
mattdurham pushed a commit to mattdurham/tempo that referenced this pull request Jun 18, 2026
…afana#3367)

* Precalculate and reuse the vParquet3 schema before opening blocks

This saves a small amount of CPU time when blocks are opened

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants