Add support for ingester query shards - #3574
Merged
Merged
Conversation
zalegrala
commented
Apr 16, 2024
zalegrala
commented
Apr 16, 2024
zalegrala
commented
Apr 16, 2024
9 tasks
zalegrala
force-pushed
the
ingesterQueryShards
branch
from
April 17, 2024 15:48
0793eee to
42a9612
Compare
zalegrala
marked this pull request as ready for review
April 17, 2024 16:40
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
April 17, 2024 16:40
joe-elliott
reviewed
Apr 17, 2024
knylander-grafana
left a comment
knylander-grafana
left a comment
Contributor
There was a problem hiding this comment.
Thank you for adding updates to the doc.
joe-elliott
approved these changes
Apr 18, 2024
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Add support for ingester query shards * Update changelog * Drop unused test method * Avoid boring lint error * Fix /0 panic * Fix first query param in test * Drop TODO after fixed in config * Tidy * Test for case where we skip doing too much work * Reduce shards until we are above the hardcode 1m interval threshold * Test greater than query count * Tidy * Avoid /0 * Require 5 occurrences for goconst * Set goconst to ignore tests, drop previous config * Avoid shard count checking and set interval floor * Clean and lint * Handle case where more shards than the window will tollerate * Ensure tests handle delta in both postivie and negative directions * Grow last shard to fill the gap and add test * Tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change allows the search queries against the ingesters to be broken into smaller queries based on the time span.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]