Add replication factor to block meta [1 of 3] - #3628
Merged
Conversation
mapno
marked this pull request as ready for review
April 30, 2024 14:59
mapno
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
April 30, 2024 14:59
mdisibio
reviewed
Apr 30, 2024
mdisibio
reviewed
Apr 30, 2024
Contributor
|
Running locally, not seeing replicationFactor=1 in the complete blocks flushed by the generator. It looks like newStreamingBlock is dropping it and also needs to be updated (at least vp2 and vp3) |
mapno
marked this pull request as draft
May 8, 2024 11:13
mapno
marked this pull request as ready for review
May 16, 2024 11:12
mdisibio
approved these changes
May 20, 2024
This was referenced May 21, 2024
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Add replication factor to block meta * Refactor CreateWAL func * chlog * Fixes * Add data encoding to WAL constructor * Implement in vParquet4 * Different fixes * Add test and fix cutting traces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds replication factor to the block meta and updates the compactors to use it as a grouping parameter. By default is set to 0, even when replication factor is enabled. It's only used in blocks created in the local-blocks processor in the metrics-generator.
It also contains a refactor of
CreateWALBlock(). Instead of passing individual parameters, it accepts abackend.BlockMeta. It coalesces creating new blocks for all the different encodings (v2,vParquet2,vParquet3,vParquet4).It also has a fix to the local-blocks processor when cutting traces immediately.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]