Remove hardcoded sleep in shutdown for distributor - #3687
Merged
Conversation
|
|
chodges15
marked this pull request as ready for review
May 19, 2024 02:07
chodges15
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
May 19, 2024 02:07
Collaborator
|
I had forgotten about this. We semi-recently added a I am fine with just removing the lines that sleep for 30s. They were not well thought out when they were added, but have never bothered us enough to remove. |
knylander-grafana
approved these changes
May 20, 2024
knylander-grafana
left a comment
knylander-grafana
left a comment
Contributor
There was a problem hiding this comment.
Approving doc update. Thank you for adding doc update withj your PR!
knylander-grafana
self-requested a review
May 20, 2024 21:59
Contributor
Author
|
@joe-elliott that makes way more sense, I should have used git blame to look at the existing |
Collaborator
|
I've been wanting to get rid of this forever and keep forgetting to just remove it. Thanks so much for getting this done! |
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
Co-authored-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This sleep is being removed in favor of using the configuration item
shutdown_delayfor generic server shutdown across all Tempo components introduced in #3395.Which issue(s) this PR fixes:
Fixes #2353
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]