Remove autocomplete_filtering_enabled config flag - #3729
Merged
Conversation
mapno
marked this pull request as ready for review
May 29, 2024 13:28
mapno
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
May 29, 2024 13:28
zalegrala
approved these changes
May 29, 2024
mapno
enabled auto-merge (squash)
June 21, 2024 13:04
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Remove autocomplete_filtering_enabled config flag * Remove missed reference * IT'S A BREAKING CHANGE * Last two fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removes
autocomplete_filtering_enabledfeature flag. It defaulted totruesince Nov '23 (#3178) and was mainly used to disable the feature if performance was bad.We haven't had to turn it off since a long time ago and we're now happy with its performance.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]