Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust server-less tooling for the new AWS Lambda "provided" run-times #3852

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

zatlodan
Copy link
Contributor

@zatlodan zatlodan commented Jul 9, 2024

What this PR does:

The "old" go1.x runtime is being deprecated.

Changes the CMD server-less build tooling to be compatible with the "new" AWS lambda run-times by default.

The "new" GoLang compatible AWS Lambda run-times expect an executable with the name bootstrap to be provided.
The handler configuration is ignored when using the "new" runtime.

See https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-from-the-go1-x-runtime-to-the-custom-runtime-on-amazon-linux-2/ for more info.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

@zatlodan zatlodan changed the title chore: Add compatibility with AWS lambda "provided" run-times Jul 9, 2024
@zatlodan zatlodan changed the title chore: Add default compatibility with AWS lambda "provided" run-times Jul 9, 2024
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Can you add a changelog entry specifying what's being deprecated? Thanks!

@zatlodan
Copy link
Contributor Author

LGMT. Can you add a changelog entry specifying what's being deprecated? Thanks!

Thank you, and sorry for the late response.

I've added a changelog entry.
Since this change only affects the build tooling, I didn't mark it as a breaking change,
although it might require adjustments for users relying on the previous build process.

Please let me know if any further adjustments are needed.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. This pull request will be closed in 15 days if there is no new activity.
Please apply keepalive label to exempt this Pull Request.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Sep 14, 2024
@zatlodan zatlodan requested a review from mapno September 14, 2024 00:30
@github-actions github-actions bot removed the stale Used for stale issues / PRs label Sep 15, 2024
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to be a bit more explicit with the migration.

Co-authored-by: Mario <mariorvinas@gmail.com>
@zatlodan zatlodan requested a review from mapno September 16, 2024 12:23
@zatlodan
Copy link
Contributor Author

I'd like to be a bit more explicit with the migration.

I agree, it is better to be more explicit here.
I was initially not sure if I should mark it as a breaking change, as I am not used to writing change-logs.

@zatlodan
Copy link
Contributor Author

@mapno Can we get an update on this?

@mapno
Copy link
Member

mapno commented Oct 28, 2024

LGTM, thanks for the contribution

@mapno mapno enabled auto-merge (squash) October 28, 2024 11:52
@mapno mapno merged commit 1f12bd2 into grafana:main Oct 28, 2024
16 checks passed
knylander-grafana pushed a commit that referenced this pull request Oct 29, 2024
…un-times (#3852)

* chore: compatibility with AWS lambda new runtime

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Mario <mariorvinas@gmail.com>

* doc: remove additional newline

---------

Co-authored-by: Mario <mariorvinas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants