Promote Azure v2 SDK - #3875
Merged
Merged
Conversation
zalegrala
force-pushed
the
azureV2Promote
branch
from
July 17, 2024 15:07
09291cd to
c576f3f
Compare
zalegrala
marked this pull request as ready for review
July 19, 2024 14:44
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
knylander-grafana,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
July 19, 2024 14:44
zalegrala
force-pushed
the
azureV2Promote
branch
2 times, most recently
from
July 22, 2024 13:49
09f939c to
ffe2c96
Compare
knylander-grafana
left a comment
knylander-grafana
left a comment
Contributor
There was a problem hiding this comment.
Thank you for updating the docs.
joe-elliott
approved these changes
Jul 23, 2024
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
Looks like you have some docs sadness, but excellent fix.
We've seen a number of issues go away internally when moving to v2.
zalegrala
force-pushed
the
azureV2Promote
branch
from
July 23, 2024 19:31
ffe2c96 to
c68345f
Compare
zalegrala
force-pushed
the
azureV2Promote
branch
from
July 25, 2024 13:15
087f56a to
8c34c2b
Compare
zalegrala
force-pushed
the
azureV2Promote
branch
from
July 25, 2024 16:11
8c34c2b to
12b36a2
Compare
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Promote Azure v2 SDK * Fix bug in Azure Find() to keep the tenant in the object path * Restructure tests after v1 drop * Add reminder about failing test * Comment failing test * Pin azurite version * Use new SDK for error handling * Update vendor * Update changelog and docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The v2 SDK was contributed a while ago, and we have been running it for a while now.
It is time to promote it to the default SDK for Azure. Here we make the v2 SDK
the default and only SDK for Azure, dropping the old config flag to enable it.
Comment test mocking the response on
Write(). The new SDK validates theresponses, and we'd need to setup and mock several conditions in order to
test appropriately. Note that this functionality is already being tested
against
azuritein the e2e tests.Update error handling to use the new SDK.
Pin version of
azuriteto the latest current version.Which issue(s) this PR fixes:
Related: #2952
Related: #2882
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]