Skip to content

[bugfix] Remove extra primary iter - #3903

Merged
ie-pham merged 2 commits into
grafana:mainfrom
ie-pham:panic
Jul 24, 2024
Merged

[bugfix] Remove extra primary iter#3903
ie-pham merged 2 commits into
grafana:mainfrom
ie-pham:panic

Conversation

@ie-pham

@ie-pham ie-pham commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

What this PR does: Primary iter is appended twice before. This fixes the issue in query range group by event attributes.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need a changelog entry? Is the changes in #3847 needed now?

@ie-pham
ie-pham merged commit c27bf8b into grafana:main Jul 24, 2024
mattdurham pushed a commit to mattdurham/tempo that referenced this pull request Jun 18, 2026
* remove extra primary iter

* CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants