Allow compaction disable per tenant - #3965
Merged
zalegrala merged 6 commits intoAug 15, 2024
Merged
Conversation
zalegrala
marked this pull request as ready for review
August 14, 2024 19:26
zalegrala
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer and
yvrhdn
as code owners
August 14, 2024 19:26
zalegrala
commented
Aug 14, 2024
zalegrala
force-pushed
the
tempoCompactionDisablePerTenant
branch
from
August 14, 2024 20:41
67ba83b to
6d45fc2
Compare
joe-elliott
reviewed
Aug 14, 2024
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
looking good. maybe just clarify Disabled -> CompactionDisabled? everything else is +1
zalegrala
force-pushed
the
tempoCompactionDisablePerTenant
branch
from
August 15, 2024 13:20
e7cef91 to
736cbd9
Compare
joe-elliott
approved these changes
Aug 15, 2024
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
looks good so going to approve, but if we can sneak changelog/docs in would be good
This was referenced Aug 30, 2024
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Allow compaction disable per tenant * Update mock * Rename legacy yaml key * Rename methods and fields for clarity about disablement * Rename methods and fields for clarity about disablement * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we plumb in an option to allow compaction to be disabled per tenant. This will be useful to perform certain operations on the backend which require compaction to be disabled for a period of time.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]