Cache: Read to a sized buffer - #3976
Merged
Merged
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
electron0zero,
ie-pham,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
August 19, 2024 15:51
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
| return resp, nil | ||
| } | ||
|
|
||
| buffer, err := api.ReadBodyToBuffer(resp) |
Member
There was a problem hiding this comment.
if maxItemSize is set to 0, then we will always cache, no matter the size.
is my understanding correct?
Member
There was a problem hiding this comment.
should we handle the case where maxItemSize is a negative value??
electron0zero
approved these changes
Aug 19, 2024
electron0zero
left a comment
electron0zero
left a comment
Member
There was a problem hiding this comment.
minor comments, rest lgtm 
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* Read to a sized buffer Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * removed sync pool Signed-off-by: Joe Elliott <number101010@gmail.com> * comments and correct alloc pattern Signed-off-by: Joe Elliott <number101010@gmail.com> * Added max item sz test Signed-off-by: Joe Elliott <number101010@gmail.com> * handle negative vals Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves the memory performance of the caching middleware by dropping
io.ReadAllin favor of reading to a sized buffer.Also
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]