Add disk caching in ingester SearchTagValuesV2 for completed blocks - #4069
Merged
Conversation
electron0zero
force-pushed
the
meta_cache_ingester
branch
2 times, most recently
from
September 13, 2024 16:53
ef5996d to
dcf5b65
Compare
electron0zero
force-pushed
the
meta_cache_ingester
branch
from
September 18, 2024 15:28
dcf5b65 to
4d32d79
Compare
electron0zero
changed the title
electron0zero
marked this pull request as ready for review
September 18, 2024 17:37
electron0zero
requested review from
annanay25,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
September 18, 2024 17:37
electron0zero
changed the title
mdisibio
reviewed
Sep 19, 2024
mdisibio
approved these changes
Sep 19, 2024
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…rafana#4069) * ingore /tmp dir in the root * instrument localblock seacher methods * insturment walBlock * disk cache works locally * fix fmt * fix lint * refactor the disk caching logic * add tests and cleanup * update CHANGELOG.md * address review comments * cacheKey without start and end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
cache the response for TagValuesV2 requests alongside the local blocks on the ingesters, this should speedup the autocomplete queries hitting ingesters.
In our dev env, it shows sizeable difference in p90, p95 of latency and throughout for tags that has values with high cardinality.
also updated instrumentation to make the ingester search spans more closer to the code.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]