fix_3811: send semver version in api/stattus/buildinfo for cloud deployments - #4110
Merged
Conversation
Aki0x137
requested review from
annanay25,
electron0zero,
ie-pham,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
September 22, 2024 15:39
|
|
joe-elliott
reviewed
Sep 24, 2024
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for looking into this!
I think it's close but I'm afraid it will break the way we've named our docker images. I've pinged a few team members who I think will have more a immediate understanding of how this works.
zalegrala
reviewed
Oct 1, 2024
This reverts commit 5cbd055.
Aki0x137
commented
Oct 5, 2024
joe-elliott
approved these changes
Oct 9, 2024
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
very cool improvement. thank you 🙏
Contributor
Author
|
Thanks for the patience with this PR😅🙏 |
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…oyments (grafana#4110) * fix(tools): fix github action * fix(tools): use correct ref fr v4 * fix(tools): use correct ref * fix(tools): fecth tags * fix(tools): fetch tags * fix(tools): use tag directly during build * Revert "fix(tools): use tag directly during build" This reverts commit 5cbd055. * fix(tools): inject tag as version directly during build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
image-tagtool is updated to validate and use the semver version, if present. Otherwise default to current behavior.Which issue(s) this PR fixes:
Fixes #3811
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]