Fix tempo cli arguments - #4259
Merged
Merged
Conversation
faridtmammadov
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
November 1, 2024 10:16
|
|
faridtmammadov
force-pushed
the
fix-tempo-cli-arguments
branch
from
November 1, 2024 12:54
01c5ff1 to
ab16948
Compare
joe-elliott
reviewed
Nov 1, 2024
joe-elliott
left a comment
joe-elliott
left a comment
Collaborator
There was a problem hiding this comment.
i have never used these fields and now i know they wouldn't have worked anyway.
thanks for spotting this and the fix! requesting a small change to the insecure flag. 🙏
faridtmammadov
force-pushed
the
fix-tempo-cli-arguments
branch
2 times, most recently
from
November 1, 2024 13:48
77768ab to
2b56810
Compare
joe-elliott
force-pushed
the
fix-tempo-cli-arguments
branch
from
November 1, 2024 19:01
bbf6c8d to
60e19d2
Compare
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* add option to skip s3 certificate verification * use S3User and S3Pass parameters in tempo-cli * lint Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes the unused S3Pass and S3User parameters in the CLI options by implementing them in the code. Additionally, it introduces a skip verify option to bypass SSL certificate validation when connecting to the S3 backend, enhancing flexibility for self-signed or internal certificates.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]