Remove pool goroutines from all components that don't need it - #4484
Merged
Conversation
joe-elliott
requested review from
electron0zero,
ie-pham,
javiermolinar,
mapno,
mdisibio,
stoewer,
yvrhdn and
zalegrala
as code owners
December 20, 2024 14:34
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Collaborator
Author
|
Removed change to shutdown b/c a rollout was showing no improvement. |
electron0zero
approved these changes
Dec 24, 2024
mapno
approved these changes
Jan 2, 2025
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…a#4484) * cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * remove shutdown change Signed-off-by: Joe Elliott <number101010@gmail.com> * remove space Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
A few improvements that I wanted to keep out of #4483
Complete all inflight jobs on ingester shutdown but refuse to do any new jobs. This should improve shutdown/restart time.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]