[TraceQL] Fix to put all conditions following a select clause into the second pass - #4600
Merged
mdisibio merged 3 commits intoJan 24, 2025
Merged
Conversation
mdisibio
changed the title
mdisibio
marked this pull request as ready for review
January 23, 2025 16:46
mdisibio
requested review from
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
stoewer,
yvrhdn and
zalegrala
as code owners
January 23, 2025 16:46
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
…e second pass (grafana#4600) * Fix to put all conditions following a select clause into the second pass * more tests * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Found some incorrect behavior from #2188 (comment) and this fixes it. The idea is that all clauses after a
select()operation should be considered in the second pass and optional, but it was being put in the first pass and required. Rare, but think it's worth fixing as this is a work-around for attribute == nil check.Which issue(s) this PR fixes:
Relates to #2188
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]